fix(tree): prevent tooltip for non-truncated option text (#DS-4931) - #1910
Open
KamilEmeleev wants to merge 1 commit into
Open
fix(tree): prevent tooltip for non-truncated option text (#DS-4931)#1910KamilEmeleev wants to merge 1 commit into
KamilEmeleev wants to merge 1 commit into
Conversation
|
Visit the preview URL for this PR (updated for commit 8a53070): https://koobiq-next--prs-1910-ba6bhzaz.web.app (expires Thu, 20 Aug 2026 18:27:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tree options showed a tooltip even when the text was not truncated.
KbqTreeOptionexposed onlyparentTextElement, soKbqTitleDirectivemeasured the.kbq-option-textcontainer against theoption host — which is always bigger, so every option looked overflown.
Reported on
kbq-username, but it is unchanged and correct: plain-text options were affected too.List of notable changes:
textElementso the clipping box is measured against itselfWhat should reviewers focus on?
Content marking its own
#kbqTitleTextkeeps priority, so tree-select and filter-bar should be unaffected.